[model validation]: Add verify for dummy-llama3.2-1B #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support and verification for the dummy-llama3.2-1B model. The changes include significant updates to the installation and quickstart documentation, new sample scripts for dummy-llama3.2-1B and qwen3vl_2b, and updates to the supported models list. Additionally, a patch for rejection_sampler is introduced, likely for performance optimization, and a bug fix is applied in deepseek_v2.py. My review has identified a few high-severity issues in the new sample scripts related to missing dependencies in their documentation, and a critical issue in the new rejection_sampler.py patch concerning a potential division-by-zero error that could lead to incorrect sampling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
verify the successful running of dummy-llama3.2-1B on the vllm-metax.
Test Plan
run the test python code after setting up the environment, the test inference code is under
docs/models/samples/dummy_llama_2.pyTest Result
Documentation Update
Update the doc of
docs/models/supported_models.md, adding new model in the table of text-generate model.